Fix ProportionalStackPanel layout update when IsEmpty of its children changes #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2024
Merged
…tionalStackPanel.IsCollapsed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsEmptyandProportionareProportionalStackPanel's attached properties controlling how its children should be layouted. However, before the PR those properties were not attached to the Panel's Children. Instead, they were attached to the Panel's Children's Children's. Because of that, the panel couldn't observe for changes in those properties. The code had a lot of hacks to dig into the ContentPresenter's child to extract them. This PR fixes that by attaching those properties directly to the panel's children.Fixes #321
(Additionally I've moved the attached properties to the
ProportionalStackPanelfrom theProportionalStackPanelSplitter, because logically that's where they belong to)Before:
Screen.Recording.2024-03-10.at.16.56.27.mov
After:
Screen.Recording.2024-03-10.at.16.54.34.mov