Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening the firewall if the auth servers are all unreachable #90

Closed
florida63 opened this issue Mar 15, 2015 · 8 comments
Closed

Opening the firewall if the auth servers are all unreachable #90

florida63 opened this issue Mar 15, 2015 · 8 comments
Labels
enhancement
Milestone
1.2.1

Comments

@florida63
Copy link
Contributor

see (http://dev.wifidog.org/ticket/92).
@acv
Copy link
Contributor

acv commented Mar 15, 2015

From source:

The last 2 attachments are a patch from Alex Nault from Zapbsl, compiled and tested by gbastien.

Works fine, but when the auth server is down and the auth-is-down ruleset is empty, then it does not redirect to the Uh ho! message page as it should do. If anyone has any idea why it doesn't, let me know. The code is not committed yet.

@florida63
Copy link
Contributor Author

I had seen but it's still boring to know of this patch, even if we do not integrate.
In my view, we must refocus bugs and patch present on the old wiki.

@acv
Copy link
Contributor

acv commented Mar 15, 2015

I wasn't shooting down the patch, just adding this as a requirement for a PR.

@acv acv mentioned this issue Mar 16, 2015
Merged
@mhaas mhaas added this to the 1.2.0 milestone Mar 18, 2015
@acv
Copy link
Contributor

acv commented Mar 19, 2015

The pull request is basically complete but could use more testing.

@sinkcup sinkcup modified the milestones: 1.3.0, 1.2.0 Mar 19, 2015
@mhaas mhaas modified the milestones: 1.2.0, 1.3.0 Mar 19, 2015
@mhaas
Copy link
Contributor

mhaas commented Mar 19, 2015

Does this require an update to doc/wifidog_firewall_map.dia?

@acv
Copy link
Contributor

acv commented Mar 19, 2015

Maybe, I don't have dia so I can't see (I always preferred OmniGraffle, which is what I used for the original flow diagram.)

@mhaas mhaas modified the milestones: 1.2.1, 1.2.0 Mar 23, 2015
@acv
Copy link
Contributor

acv commented Mar 23, 2015

Fix merged but leaving issue open as reminder to update NEWS file tonight.

acv added a commit to acv/wifidog-gateway that referenced this issue Mar 24, 2015
@acv
Update NEW files for wifidog#90
039307a
@acv acv mentioned this issue Mar 24, 2015
Merged
acv added a commit that referenced this issue Mar 24, 2015
@acv
Merge pull request #150 from acv/news-update
fe65d3e 
Update NEWS files for #90
@acv
Copy link
Contributor

acv commented Mar 24, 2015

NEWS updated, all done here.

@acv acv closed this as completed Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.2.1
Development

No branches or pull requests
4 participants
@mhaas @acv @florida63 @sinkcup