add option of saving pid file #217
Conversation
Signed-off-by: tymon <tymon@tymon-32bit.(none)>
|
The build is successful in my openwrt-trunk, could you please show me more hints ? |
|
So there's two things here. Technically, the code does not fail to build. But the non-SSL integration build are set to convert all warnings to errors. The SSL build don't run with that compiler flag so they succeed. The error itself is that getpid() returns pid_t which is a signed long on linux. Yet the printf() specifies an unsigned long. %zu might be the right string to use here, I believe that current OpenWrt use a C99 compliant toolchain. |
|
thank you for suggestions, I will commit another patch for it later. |
Signed-off-by: tymon <banglang.huang@foxmail.com>
|
I 'd already modified the commit just now, please check it. |
|
Hey, travis (or rather, the C compiler) does not like some of your code. Can you check that and fix the warning? |
Signed-off-by: tymon <banglang.huang@foxmail.com>
|
I can not see the Travis CI build details, could you show me more information so that I can correct my code ? |
|
Of course I really want to know where is the warning occur. |
|
You can see the build log here: https://travis-ci.org/wifidog/wifidog-gateway/jobs/72659411 |
Signed-off-by: tymon.huang <banglang.huang@foxmail.com>
|
Ok, I got it, all build error has been fixed. |
| { | ||
| if (pf) { | ||
| FILE *f = fopen(pf, "w"); | ||
| if (f) { |
There was a problem hiding this comment.
Can you provide a meaningful error message to the user if the fopen call fails?
|
Much appreciated. I added some comments to your patch - we probably need to check the return values. Otherwise coverity will complain because we're not programming defensively. |
…gful message if failed Signed-off-by: tymon.huang <banglang.huang@foxmail.com>
|
well, thanks mhaas' suggestions, I add some meaningful message to user and check the return value of fclose as well. |
| } | ||
|
|
||
| /* fopen return NULL, open file failed */ | ||
| debug(LOG_ERR, "fopen() on flie %s was failed (%s)", pf, strerror(errno)); |
There was a problem hiding this comment.
I believe there is a small control flow error here: the call do debug call will always fire regardless of the value of f.
There was a problem hiding this comment.
I am sorry to make a stupid mistake.
Signed-off-by: tymon.huang <banglang.huang@foxmail.com>
|
Anything else needed to be modified ? |
|
No, it's perfect now. Thanks for the PR and implementing the changes! |
Signed-off-by: Tymon banglang.huang@foxmail.com
I think wifidog-gateway should have a option to save pid file, so I add this function.