Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the --show-accounts flag? #234

Closed
fvictorio opened this issue Nov 30, 2021 · 2 comments
Closed

Consider removing the --show-accounts flag? #234

fvictorio opened this issue Nov 30, 2021 · 2 comments

Comments

@fvictorio
Copy link
Contributor

The latest versions of Hardhat are a bit smarter about the accounts being shown. Now we only show the private keys of the configured accounts if the default mnemonic is used, but we hide them if not.

Assuming that the idea of hiding the accounts by default was to protect user's private keys (which makes a lot of sense!), would you consider removing that behavior now that Hardhat does the right thing?

The reason to ask for this is that users get confused by the lack of output now and then, since they don't realize that hardhat-deploy is adding that behavior, which conflicts with what our docs show.

@wighawag
Copy link
Owner

Done, by increasing the peer dependency of hardhat to 2.6.8 in hardhat-deploy 0.9.21

@fvictorio
Copy link
Contributor Author

Thank you!

Vsevo1od added a commit to Vsevo1od/hardhat-deploy that referenced this issue May 5, 2023
This flag was removed in wighawag#234
But the docs were not updated
0xcryptofire added a commit to 0xcryptofire/hardhat_deploy_engine_v2 that referenced this issue Mar 27, 2024
This flag was removed in wighawag/hardhat-deploy#234
But the docs were not updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants