Add arg configuration to proxyAdmin and allow name to act as artifact

[outdoteth]

At the moment [owner] is passed as the constructor argument to every custom AdminContract in the proxy option. This is not desireable since a lot of ProxyAdmin contracts will take different constructor arguments. Specifically, for my use case the OpenZeppelin ProxyAdmin has no constructor at all.

This change allows you to specify what arguments get passed to the AdminContract.

This change also adds a fall back to the artifact being the name if no artifactName is specified. So here, because no artifactName is specified, both the name and artifact is "ProxyAdmin".

For example:

    await deploy('Foo', {
        from: deployer,
        proxy: {
            proxyContract: "TransparentUpgradeableProxy",
            viaAdminContract: { 
                name: "ProxyAdmin", // Use "ProxyAdmin" as the artifact as well as the name
                args: [], // Allows you to pass in custom arguments for ProxyAdmin constructor here
            },
        },
    });

[outdoteth]

Just a side note, I think the naming could be improved too. viaAdminContract is a little verbose. Just adminContract would be more consistent imo.

[wighawag]

it should not be a console.log as this would show up everywhere including test output

[outdoteth]

Ok I removed the log completely as I see you have done in here:

[outdoteth]

@wighawag just pinging.

[wighawag]

Hi Dylan, sorry did not find the time yet to fully review it, but in principle it looks good. Hopefully I ll find some time before I am back from my travel.

[marcelomorgado]

Hi guys, any update here? Would be useful having args for custom proxy admin contracts.

[marcelomorgado]

Hi guys, any update here? Would be useful having args for custom proxy admin contracts.

Sorry @Dylan-Kerler @wighawag but I'm really needing this 🤣

[outdoteth]

Hey @marcelomorgado no update from me. AFAIK this is good to merge, it’s just waiting on @wighawag to review it.

[wighawag]

I ll try to review soon.

By the way regarding openzeppelin proxy admin and the impossibility for it to be provided an specific owner at construction time, the hardhat-deploy proxy admin is a simple modification to it so you do not waste gas by setting the owner twice, see discussion here : OpenZeppelin/openzeppelin-contracts#2639 (comment)