Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zksync compatibility #494

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

4000D
Copy link

@4000D 4000D commented Oct 25, 2023

Current implementation doesn't support below features on zksync era network:

  1. deploy diamond proxy (as default faucets are not compiled with zksolc)
  2. deploy and upgrade transparent proxy (as eth_getTransactionByHash response is changed not to include factoryDeps)

This PR fixes (1) by adding custom options to DiamondOptions and fixes (2) by comparing deployTransaction.data (which is ContractDeployer.create(salt, bytecodeHash, input)).

Sample repository implements hardhat project and upgrade transparent proxy and diamond proxies on zksync era goerli testnet. It uses below custom deterministic deployment

{
  factory: "0x8FE821481141E18c76652787e5612377A410FfF1",
  deployer: "0x226210a1Cc4aDcF222D1852767C04aa34F27eeDF",
  funding: "10200000000000000",
  signedTx: "0x71f904f580840ee6b280840ee6b28083060dc494000000000000000000000000000000000000800680b8849c4d535b00000000000000000000000000000000000000000000000000000000000000000100001fba45126ea8d92d3dead7d20dde284e882ed711e885c33b61ce18669500000000000000000000000000000000000000000000000000000000000000600000000000000000000000000000000000000000000000000000000000000000820118808082011894226210a1cc4adcf222d1852767c04aa34f27eedf82c350f903e3b903e0000200000000000200010000000103550000006001100270000000180010019d0000008001000039000000400010043f00000001012001900000003f0000c13d000000200100003900000001031003670000000002000031000000200120008a0000001f0510018f0000000504100272000000170000613d00000000060000190000000507600210000000000873034f000000000808043b00000000008704350000000106600039000000000746004b000000100000413d000000000605004b000000250000613d00000003055002100000000504400210000000000604043300000000065601cf000000000656022f000000000343034f000000000303043b0000010005500089000000000353022f00000000035301cf000000000363019f00000000003404350000000103000367000000000403043b000000000300041600000000050004140000001a060000410000000000600435000000040040043f0000006004000039000000440040043f000000a40220008a000000640020043f0000001802000041000000180450009c00000000040200190000000004054019000000180510009c00000000010280190000006001100210000000c002400210000000000112019f0000001b011001c7000000000203004b000000470000c13d0000800602000039005a00550000040f0000004b0000013d0000000001000416000000000101004b000000500000c13d00000020010000390000010000100443000001200000044300000019010000410000005b0001042e000080090200003900008006040000390000000105000039005a00550000040f0000000102200190000000500000613d000000000101043b000000000201004b000000520000c13d00000000010000190000005c0001043000000000001004350000001c010000410000005b0001042e00000058002104210000000102000039000000000001042d0000000002000019000000000001042d0000005a000004320000005b0001042e0000005c0001043000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000ffffffff00000002000000000000000000000000000000400000010000000000000000003cda33511d41a8a5431b1770c5bc0ddd62e1cd30555d16659b89c0d60f4f9f57020000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000140000000c00000000000000000000000000000000000000000000000000000000000000000000000000000000a20543cb11aed745fd153a7360dbcaf11dbbd4e03d0a702f1a00fc6c93abb321b8410ebe89955ee8a053f2da6f9cc96b8e1e7d916b898af4c7a96e3789830ad4ad8c09a4d8f70ce5fa32f53a305a4ed3fc0aba829c5f9db6ad8c0e60602ad16a04521bc0",
}

@wighawag
Copy link
Owner

Thanks for the PR

I am not sure I like the approach of adding more parameters for the default facets

You might have noticed but I have a line defaultLoopeFacet?: boolean; commented out where the idea was that you can provide your own default facet by simply disabling the default one and providing your own one through the normal facets params

@4000D
Copy link
Author

4000D commented Oct 26, 2023

I changed to combinevia*Contract option and default*Contract option.

I think there are some trade-offs in providing default facets to normal facet option but it may require complex change code when deploy DiamondERC165Init.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants