Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant name variable #495

Merged

Conversation

technophile-04
Copy link
Contributor

@technophile-04 technophile-04 commented Oct 29, 2023

Was just trying to go through and noticed this, I am sure I am missing some context as to why we had a let name variable

does this somehow relate to #325 (comment) ?

@technophile-04 technophile-04 changed the title remove redundant variable remove redundant name variable Oct 29, 2023
@wighawag
Copy link
Owner

Thanks for the PR!

I do not recall but It might be that previous code had some way to change the name to something else than the filename

@wighawag wighawag merged commit e6cb832 into wighawag:master Oct 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants