Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some comments #549

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: fix some comments #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ export function mergeABIs(
return false;
}
if (!existingEthersFragment) {
return v.name === fragment.name; // TODO fallback and receive hanlding
return v.name === fragment.name; // TODO fallback and receive handling
}

if (
Expand All @@ -606,7 +606,7 @@ export function mergeABIs(
} else if (newEthersFragment.type === 'event') {
return existingEthersFragment.format() === newEthersFragment.format();
} else {
return v.name === fragment.name; // TODO fallback and receive hanlding
return v.name === fragment.name; // TODO fallback and receive handling
}
});
if (foundSameSig) {
Expand Down
2 changes: 1 addition & 1 deletion types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ export interface DeploymentsExtension {
// deploy diamond based contract (see section below)
deploy(name: string, options: DiamondOptions): Promise<DeployResult>;
};
deterministic( // return the determinsitic address as well as a function to deploy the contract, can pass the `salt` field in the option to use different salt
deterministic( // return the deterministic address as well as a function to deploy the contract, can pass the `salt` field in the option to use different salt
name: string,
options: Create2DeployOptions
): Promise<{
Expand Down