Fix dismissability issues with tooltips that have custom View. #2169
Conversation
| @@ -5,6 +5,7 @@ | |||
| android:orientation="vertical" | |||
| android:paddingStart="16dp" | |||
| android:paddingTop="16dp" | |||
| android:paddingBottom="16dp" | |||
There was a problem hiding this comment.
Adding 16dp will show too much space on the bottom (on Samsung S9). Would it be possible to change it to 8dp?
There was a problem hiding this comment.
Here's how it looks on my Pixel 2:
Are we sure the Balloon updates are ready for prime time?
There was a problem hiding this comment.
I see what's happening there.
The library uses the width instead of height to adjust the tooltip's height.
My Pixel 3 XL also has a similar issue you have on Pixel 2 (with android:paddingBottom="16dp" changes)
It would be better to change android:padding='16dp' for a proper fix.
There was a problem hiding this comment.
Should we add the ScrollView back to the tooltip custom views? I will report this issue to the author. 🆘
bab1c7b#diff-b973be46f02dbcc9ce6123253a46d143a264dd1713a7f15bc7eac15fbb80eaa3
|
@cooltey I've removed the layout changes from this PR, so this can just be fixing the logic of dismissing. After this, we can continue to tweak the layouts separately, or pull in more updates from the balloon library. |
No description provided.