generate report for a single course #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maneeshatejani1
force-pushed
the
maneesha/generate-report-for-single-course
branch
from
5e444c6 to
93f3523
Compare
mumarkhan999
reviewed
Sep 7, 2021
| @@ -52,6 +52,14 @@ | |||
| </a> | |||
| </div> | |||
| % endif | |||
| % if user.is_staff: | |||
| <div class="mobile-nav-item hidden-mobile nav-item nav-tab"> | |||
| <a class="tab-nav-link discover-new-link" href="/admin_dashboard" | |||
| @@ -0,0 +1,11 @@ | |||
|
|
|||
| """Common settings for Admin Dashboard""" | |||
There was a problem hiding this comment.
To keep the things consistent, kindly add docstrings in other newly added python files as well.
"""
My docstring here.
"""
And follow this pattern
| @@ -0,0 +1,79 @@ | |||
| (function() { | |||
| 'use strict'; | |||
| var getCookie, ReportDownloads; | |||
There was a problem hiding this comment.
Kindly try to use let in place of var as much as possible to keep the scope of variables limited.
There was a problem hiding this comment.
sure, taken note
|
|
||
| <br><br><br> | ||
|
|
||
| <p><input type="button" name="list-profiles-csv" value="${_("Download profile information as a CSV")}" data-endpoint="${ section_data['key']['get_students_features_url'] }" data-csv="true"></p> |
There was a problem hiding this comment.
Kindly, indent this to increase the readability
<p>
<input ....>
....
</input>
</p>
| @ensure_csrf_cookie | ||
| @cache_if_anonymous() | ||
| def course_reports(request): | ||
| courses_list = [] |
There was a problem hiding this comment.
Not commenting anything on this function as I assume you are using it just for testing purposes.
mumarkhan999
approved these changes
Sep 9, 2021
maneeshatejani1
force-pushed
the
maneesha/generate-report-for-single-course
branch
from
d8091cf to
5e0ed9e
Compare
tehreem-sadat
pushed a commit
that referenced
this pull request
Sep 26, 2021
fix in admin_dashboard app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate course report for selected course