-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a recommended config #249
Comments
Given this is recommended rather than automatically enforced, a more opinionated one isn't out of the question, if there are others.
That could work as a starting point.
That seems possibly a bit too magical? And breaks for yarn users etc. Eh. I'd be interested to hear from potential users outside the Wikimediverse. |
I was thinking more if there were an "engine" setting in package.json for jQuery, rather than inspecting the dependencies list (although the magical behaviour could be a fallback as along as there's a way to correct it). Or we could introduce a setting that defaults to latest stable? |
Now-recommended rules: - no-animate-toggle - no-animate - no-class-state - no-constructor-attributes - no-deferred - no-extend - no-fx-interval - no-global-selector - no-jquery-constructor - no-load-shorthand - no-on-ready - no-parse-html-literal - no-ready - no-sizzle - variable-pattern Fixes #249.
Currently this would probably only contain
variable-name
as half the rules depend on that being enforced.It would be nice to enforce a deprecated config automatically but we can't tell which version of jQuery they are using.
We could put
deprecated-2.latest
in there as 1.x and 2x are EOL (jquery/jquery.com#162).It may also be possible read the jQuery version from package.json.
The text was updated successfully, but these errors were encountered: