Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a recommended config #249

Open
edg2s opened this issue Jun 18, 2020 · 2 comments · May be fixed by #317
Open

Create a recommended config #249

edg2s opened this issue Jun 18, 2020 · 2 comments · May be fixed by #317

Comments

@edg2s
Copy link
Member

edg2s commented Jun 18, 2020

Currently this would probably only contain variable-name as half the rules depend on that being enforced.

It would be nice to enforce a deprecated config automatically but we can't tell which version of jQuery they are using.

We could put deprecated-2.latest in there as 1.x and 2x are EOL (jquery/jquery.com#162).

It may also be possible read the jQuery version from package.json.

@jdforrester
Copy link
Member

Currently this would probably only contain variable-name as half the rules depend on that being enforced.

Given this is recommended rather than automatically enforced, a more opinionated one isn't out of the question, if there are others.

It would be nice to enforce a deprecated config automatically but we can't tell which version of jQuery they are using.

We could put deprecated-2.latest in there as 1.x and 2x are EOL (jquery/jquery.com#162).

That could work as a starting point.

It may also be possible read the jQuery version from package.json.

That seems possibly a bit too magical? And breaks for yarn users etc. Eh. I'd be interested to hear from potential users outside the Wikimediverse.

@edg2s
Copy link
Member Author

edg2s commented Jun 18, 2020

I was thinking more if there were an "engine" setting in package.json for jQuery, rather than inspecting the dependencies list (although the magical behaviour could be a fallback as along as there's a way to correct it).

Or we could introduce a setting that defaults to latest stable?

edg2s pushed a commit that referenced this issue Jun 4, 2024
jdforrester added a commit that referenced this issue Jun 5, 2024
Now-recommended rules:
- no-animate-toggle
- no-animate
- no-class-state
- no-constructor-attributes
- no-deferred
- no-extend
- no-fx-interval
- no-global-selector
- no-jquery-constructor
- no-load-shorthand
- no-on-ready
- no-parse-html-literal
- no-ready
- no-sizzle
- variable-pattern

Fixes #249.
@jdforrester jdforrester linked a pull request Jun 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants