test: Add test for 3-values border-radius #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help increase the code coverage and overall stability. This wasn't previously done because the test runner insisted on roundtripping all test cases, which isn't possible in this case. > input: 1px 2px 3px -> output: 2px 1px 2px 3px > // Same as: > input: 1px 2px 3px 2px -> output: 2px 1px 2px 3px and: > input: 2px 1px 2px 3px -> output: 1px 2px 3px 2px > // of which the output is effectively the same as "1px 2px 3px" When 3 values are given in CSS, the fourth value is implied to be the same as the second value: > (top, [right=top], [bottom=top], [left=right]) Add a "roundtrip" setting to disable roundtripping where needed.
jdforrester
reviewed
Oct 23, 2017
| @@ -29,7 +30,7 @@ module.exports = function ( grunt ) { | |||
| output | |||
| ); | |||
|
|
|||
| if ( !noop ) { | |||
There was a problem hiding this comment.
Were we never setting noop, then?
There was a problem hiding this comment.
Yes, we were and still are. On line 20. A test case's first value is the input, and the optional second value is the expected output after flipping. If no second value is provided (which we do in quite a few cases), then we simply assert the value is not affected by flipping (e.g. non-flippable properties and things like @noflip). In those cases, no need for a roundtrip given it would be the same assertion.
By default, we always roundtrip if the test isn't noop. But this commit introduces the ability to disable roundtrip.
jdforrester
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help increase the code coverage and overall stability.
This wasn't previously done because the test runner insisted
on roundtripping all test cases, which isn't possible in this case.
input: 2px 1px 2px 3px -> output: 1px 2px 3px 2px
// of which the output is effectively the same as "1px 2px 3px"
(top, [right=top], [bottom=top], [left=right])