Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark #63

Merged
merged 5 commits into from
May 10, 2019
Merged

Add benchmark #63

merged 5 commits into from
May 10, 2019

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Jun 24, 2018

Minimal no-dependencies benchmarker, inspired by Node.js' own benchmark runner.

Using the same fixtures as php-cssjanus at https://github.com/cssjanus/php-cssjanus/blob/v1.2.1/test/CSSJanusBenchmark.php.

Krinkle added 2 commits June 24, 2018 22:57
eslint-config-wikimedia   0.3.0  →   0.5.0
grunt                     1.0.2  →   1.0.3
grunt-contrib-watch       1.0.0  →   1.1.0
grunt-eslint             18.0.0  →  20.2.0
grunt-jsonlint            1.0.8  →   1.1.0

grunt-eslint has a newer version (21.0) that requires Node 6,
given we still support Node 4, staying on the latest before it.
Uses the same fixtures as the benchmarks for php-cssjanus.
@Krinkle Krinkle requested a review from a team June 24, 2018 22:01
@Krinkle Krinkle requested a review from trevorparscal July 18, 2018 00:05
@Krinkle Krinkle requested review from catrope and removed request for a team December 29, 2018 20:49
Copy link
Member

@jdforrester jdforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. Land in 1.4.0?

@jdforrester jdforrester merged commit b05caf9 into master May 10, 2019
@jdforrester jdforrester deleted the bench branch May 10, 2019 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants