build: Add npm-run command for 'grunt site' #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously one had to install grunt-cli globally in the local shell (or use npx). Instead, add a preset command that uses the locally installed copy of grunt, same as for `npm test`. Also, update the destination directory option to be based on an environment variable because passing options from an npm script is not user-friendly (would have to require four dashes instead of two, e.g. `npm run site -- --foo bar`), and more importantly, Grunt specifically does not support this call pattern and instead tries to look for a task called "--foo". Avoid that issue by using an env variable instead.
jdforrester
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously one had to install grunt-cli globally in the local
shell (or use npx). Instead, add a preset command that uses
the locally installed copy of grunt, same as for
npm test.Also, update the destination directory option to be based
on an environment variable because passing options from an
npm script is not user-friendly (would have to require four dashes
instead of two, e.g.
npm run site -- --foo bar), and moreimportantly, Grunt specifically does not support this call
pattern and instead tries to look for a task called "--foo".
Avoid that issue by using an env variable instead.