Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cssjanus.js #73

Closed
wants to merge 1 commit into from
Closed

Update cssjanus.js #73

wants to merge 1 commit into from

Conversation

reedy
Copy link
Member

@reedy reedy commented May 10, 2019

Brings in minor regex changes from https://github.com/cssjanus/php-cssjanus/pull/19

Escaping differences are already present

Brings in minor regex changes from https://github.com/cssjanus/php-cssjanus/pull/19

Escaping differences are already present
@jdforrester
Copy link
Member

Should we have tests?

@reedy
Copy link
Member Author

reedy commented May 10, 2019

Warning: Invalid regular expression: /(\/\*\!?\s*@noflip\s*\*\/(?!((?:[_a-z0-9-]|[^\u0020-\u007e]|(?:(?:(?:\\[0-9a-f]{1,6})(?:\r\n|\s)?)|\\[^\r\n\f0-9a-f]))|\r?\n|\s|#|\:|\.|\,|\+|>|\(|\)|\[|\]|=|\*=|~=|\^=|'[^']*'])*+{)[^;}]+;?)/: 

@reedy
Copy link
Member Author

reedy commented May 10, 2019

The PHP changes aren't compatible for the js version... I guess #74 covers this difference (for now at least)

@Krinkle
Copy link
Member

Krinkle commented May 10, 2019

Yep. Nothing we can do at the moment. Closing for now.

@Krinkle Krinkle closed this May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants