Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent flipping percentages in CSS color functions #93

Closed

Conversation

AbhineetSaha
Copy link

This PR updates the calculateNewBackgroundPosition function to skip flipping percentages when they appear inside CSS color functions (e.g., hsl(), hsla(), color(), lab(), etc.). This ensures that saturation/lightness and other non-positional percentages remain unchanged, fixing [issue #92].

Original Code:
Screenshot 2024-12-11 at 10 05 24

Fixed Code:
Screenshot 2024-12-11 at 10 04 28

@wikimedia-helper-bot-for-github

👋 Hi @AbhineetSaha,

Thank you for contributing to Wikimedia! This Github repository is a read-only mirror.
The project uses Gerrit for code review.
Please submit your pull request to Gerrit, so your code changes can be reviewed.

If you are interested in sticking around within the Wikimedia community, please take a look at https://www.mediawiki.org/wiki/New_Developers
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant