Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watchlist navigation bugs #4970

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Watchlist navigation bugs #4970

merged 2 commits into from
Sep 13, 2024

Conversation

mazevedofs
Copy link
Collaborator

@mazevedofs mazevedofs commented Sep 13, 2024 •
edited
Loading

Phabricator: https://phabricator.wikimedia.org/T374035 & https://phabricator.wikimedia.org/T373965

Notes

  • This PR fixes two watchlist-related bugs:
  1. Unable to navigate to the watchlist from the toasts after adding an article.
  2. Unable to navigate to the user submenus from the watchlist cell

Test Steps

  1. Go to an article, add it to your watchlist
  2. Click on the "Go to Watchlist" button on the toast
  3. You should be able to navigate to the watchlist
  4. On the watchlist view, click on the user button
  5. Make sure you can navigate to all the options
  6. Go to Watchlist from settings
  7. Make sure you can repeat items 4 and 5

@l-olson1214 l-olson1214 self-requested a review September 13, 2024 19:01
@l-olson1214 l-olson1214 merged commit bad1397 into 7.5.9 Sep 13, 2024
5 checks passed
@mazevedofs mazevedofs deleted the watchlist-bugs branch September 13, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-olson1214 l-olson1214 l-olson1214 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazevedofs @l-olson1214