Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send is_temp and user_is_temp to MEP #5012

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Send is_temp and user_is_temp to MEP #5012

wants to merge 5 commits into from

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T376403

Notes

This PR sends is_temp and user_is_temp to MEP if the user is in a temporary auth state on any wiki. I had to go a little further and literally check the cookie usernames here, because there were pilot wiki states where the cookie existed but currentUserCache (which represents the auth states of the primary app language) did not have the state. We may be able to simplify once this is rolled out across all wikis, but for now this is the most simple way I could get around that.

Test Steps

  1. Change WMFLogging.h to log everything
  2. Fresh launch on app, ensure you are logged out. Watch the payloads as you click around and confirm you see is_anon = true and is_temp = false send in the events.
  3. Edit an article on Test Wiki. Confirm that about halfway through publishing, you start to see is_anon = true and is_temp = true. If an event goes through the EditAttemptStep funnel, you will see a payload with user_is_temp = true and is_anon = true.
  4. Continue clicking around and confirm you continue to see is_anon = true and is_temp = true logged.
  5. Log into the app. After login and clicking around, confirm you now see is_anon = false and is_temp = false.

@tonisevener tonisevener marked this pull request as draft October 9, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant