Send is_temp and user_is_temp to MEP #5012
Draft
+98
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T376403
Notes
This PR sends
is_temp
anduser_is_temp
to MEP if the user is in a temporary auth state on any wiki. I had to go a little further and literally check the cookie usernames here, because there were pilot wiki states where the cookie existed butcurrentUserCache
(which represents the auth states of the primary app language) did not have the state. We may be able to simplify once this is rolled out across all wikis, but for now this is the most simple way I could get around that.Test Steps
is_anon = true
andis_temp = false
send in the events.is_anon = true
andis_temp = true
. If an event goes through the EditAttemptStep funnel, you will see a payload withuser_is_temp = true
andis_anon = true
.is_anon = true
andis_temp = true
logged.is_anon = false
andis_temp = false
.