Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to delete all values, Base.drop deprecation, avoid Pkg.dir #11

Merged
merged 6 commits into from
Nov 13, 2017
Merged

option to delete all values, Base.drop deprecation, avoid Pkg.dir #11

merged 6 commits into from
Nov 13, 2017

Conversation

tanmaykm
Copy link
Contributor

@tanmaykm tanmaykm commented Nov 13, 2017 •
edited
Loading

  • Allow delete of all values for a key when no val is supplied to the delete! method. This is done by passing a C_NULL as value (as in the C API doc).
  • handle deprecation of Base.drop by importing it only in Julia v0.5
  • use dirname instead of Pkg.dir to make it compatible to loading via LOADPATH

@tanmaykm
allow delete without comparing value
bf93948 
This will allow delete of all values for a key when no `val` is supplied to the `delete!` method.
This is done by passing a `C_NULL` as value (as in the C API doc).
@tanmaykm
handle deprecation of Base.drop
7d9bb22
@tanmaykm
use dirname instead of Pkg.dir
abefaaf 
to make it compatible to loading via `LOADPATH`
@coveralls
Copy link

coveralls commented Nov 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 61.881% when pulling abefaaf on tanmaykm:tan/dropdepr into 59ac5ab on wildart:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.881% when pulling abefaaf on tanmaykm:tan/dropdepr into 59ac5ab on wildart:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.881% when pulling abefaaf on tanmaykm:tan/dropdepr into 59ac5ab on wildart:master.

@coveralls
Copy link

coveralls commented Nov 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 73.659% when pulling 42b3224 on tanmaykm:tan/dropdepr into 117182b on wildart:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.659% when pulling 42b3224 on tanmaykm:tan/dropdepr into 117182b on wildart:master.

@wildart wildart merged commit 6d56c88 into wildart:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanmaykm @coveralls @wildart