Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key Iterator & 1.0 compatibility #19

Merged
merged 7 commits into from
Aug 30, 2018
Merged

Key Iterator & 1.0 compatibility #19

merged 7 commits into from
Aug 30, 2018

Conversation

madsciencetist
Copy link
Contributor

Builds on top of #18 with minor additional 0.7 compatibility fixes

Adds an iterator type over LMDB keys and a keys method to return one. To iterate over Int keys and Float64 values,

for key in keys(cur, Int)
    value = get(txn, dbi, key, Float64)

Rene Donner and others added 5 commits March 22, 2018 13:54
fixes for 0.7
f406d16
use Compat instead of VERSION test
a81b2c9
remove Nullable
452d88c
@madsciencetist
0.7 compatibility
f71466d
@madsciencetist
Key iterator
8aa413f 
Iterate over a database with String keys with:

	for key in keys(cursor, String)
@coveralls
Copy link

coveralls commented Aug 10, 2018 •
edited
Loading

Coverage Status

Coverage increased (+21.9%) to 97.403% when pulling 52737b1 on madsciencetist:key_iterator_getter into 1955129 on wildart:master.

@madsciencetist madsciencetist changed the title Key Iterator (0.7+) Key Iterator Aug 10, 2018
@wildart
Copy link
Owner

wildart commented Aug 14, 2018

You should target 0.7/1.0 and drop compatibility with lower versions.

wildart
wildart reviewed Aug 14, 2018
View reviewed changes
Copy link
Owner

@wildart wildart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop support of older Julia versions

test/runtests.jl Outdated
using Base.Test
using Compat
using Compat.Test
push!(LOAD_PATH, joinpath(dirname(@__FILE__), "../src"))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to modify LOAD_PATH.

REQUIRE Outdated
@@ -1,2 +1,3 @@
julia 0.6
BinDeps
Compat
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop Compat & target 0.7+

src/LMDB.jl Outdated
isdefined(:Docile) && eval(:(@document))
using Compat

if VERSION < v"0.7"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove any code incompatible with 0.7 in all files.

@codecov-io
Copy link

codecov-io commented Aug 19, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@1955129). Click here to learn what that means.
The diff coverage is 97.61%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #19   +/-   ##
========================================
  Coverage          ?   97.4%           
========================================
  Files             ?       5           
  Lines             ?     154           
  Branches          ?       0           
========================================
  Hits              ?     150           
  Misses            ?       4           
  Partials          ?       0
Impacted Files Coverage Δ
src/txn.jl 100% <100%> (ø)
src/common.jl 100% <100%> (ø)
src/env.jl 94.54% <100%> (ø)
src/dbi.jl 100% <100%> (ø)
src/cur.jl 97.29% <94.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1955129...d327282. Read the comment docs.

@madsciencetist
Copy link
Contributor Author

Finally figured out Travis/Pkg3 enough to get tests to pass

@madsciencetist
Copy link
Contributor Author

I set version to 0.1.0 in the Project.toml file with the expectation that you will tag the code as v0.1.0. Let me know if you'd prefer a different version number (I just need it to be greater than 0.0.4)

@madsciencetist
Copy link
Contributor Author

Fixes #7

@madsciencetist madsciencetist changed the title Key Iterator Key Iterator & 1.0 compatibility Aug 28, 2018
@wildart wildart merged commit 637a483 into wildart:master Aug 30, 2018
This was referenced Aug 30, 2018
Closed
Closed
@madsciencetist
Copy link
Contributor Author

Thanks!

@madsciencetist madsciencetist deleted the key_iterator_getter branch August 31, 2018 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildart wildart wildart left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@madsciencetist @coveralls @wildart @codecov-io