Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the proceed async message #237

Merged
merged 1 commit into from
Mar 21, 2017

Conversation

stuartwdouglas
Copy link
Contributor

This is needed for legacy clients to solve https://issues.jboss.org/browse/JBEAP-9669

I am not sure if it should be send for all protocol versions, or only for versions 1 and 2

@dmlloyd
Copy link
Member

dmlloyd commented Mar 21, 2017

We should only send it for 1 and 2, and only for async methods returning Future. For version 3, methods returning Future are always treated as async by the client.

For all versions, void async methods should be reported as "complete" immediately.

@stuartwdouglas
Copy link
Contributor Author

I have updated it to only send for older versions. In terms of only sending for methods that return Future I think that should be the responsibility of the Association (see https://github.com/stuartwdouglas/wildfly/tree/ejb-async-fix).

@dmlloyd
Copy link
Member

dmlloyd commented Mar 21, 2017

Sounds good.

@dmlloyd dmlloyd merged commit 3ab2528 into wildfly:master Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants