Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EJBCLIENT-424] EJB remote invocation response payload contain ContextData not part of 'jboss.returned.keys' #545

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

jbaesner
Copy link
Contributor

@jbaesner jbaesner commented Jul 1, 2022

…tData not part of 'jboss.returned.keys'

When unmashalling an incoming EJB request, ContextData to preserve is collected
in a 'retainContextDataKeys' Set. These contain all keys provided by the client
as comma separated list for the key 'jboss.returned.keys', as well as internally
added keys. Before marshalling the response the attachments are reduced to the
keys contained in the 'retainContextDataKeys' Set.
Copy link
Contributor

@tadamski tadamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -799,6 +803,7 @@ public void convertToStateful(final SessionID sessionId) throws IllegalArgumentE

public Resolved getRequestContent(final ClassLoader classLoader) throws IOException, ClassNotFoundException {
classResolver.setClassLoader(classLoader);
Set<String>retainContextDataKeys = new HashSet<>();
int responseCompressLevel = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a space before the variable name?

@chengfang chengfang merged commit e21722e into wildfly:4.0 Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants