Update quickstarts to use Glow #895
Conversation
Port enhanced quickstarts to Glow
Add Glow plugin examples
Add module Develop demo app Document QS
…view-31.0.0.Final
Add micrometer and opentelemetry with Glow support
Sync Glow Preview branch with 31.0.0.final
Glow preview 31.0.0.final
Add glow rendering to README-source of enhanced quickstarts
Glow preview 31.0.0.final
Also upgrade to 5.0.0.Final of the WildFly maven plugin
|
/retest |
.github/workflows/project_ci.yml
Outdated
| wildfly-branch: ${{ github.base_ref }} | ||
| # There is no upstream glow-preview branch. The QS glow-preview branch targets WildFLy main | ||
| #wildfly-branch: ${{ github.base_ref }} | ||
| wildfly-branch: main |
There was a problem hiding this comment.
I think now should be reverted?
.github/workflows/project_ci.yml
Outdated
| wildfly-repo: "wildfly/wildfly" | ||
|
|
||
| Test-build-with-deps-matrix: | ||
| name: BUILD WITH DEPS - JDK${{ matrix.jdk }} - ${{ matrix.os }} | ||
| runs-on: ${{ matrix.os }} | ||
| needs: WildFly-build | ||
| if: |
.github/workflows/quickstart_ci.yml
Outdated
| wildfly-branch: ${{ github.base_ref }} | ||
| # There is no upstream glow-preview branch. The QS glow-preview branch targets WildFLy main | ||
| #wildfly-branch: ${{ github.base_ref }} | ||
| wildfly-branch: main |
There was a problem hiding this comment.
I think now should be reverted?
| @@ -20,7 +20,8 @@ env: | |||
| MATRIX_JDK: '"11", "17"' | |||
| MATRIX_OS: '"ubuntu-latest"' | |||
| SERVER_PROVISIONING_SERVER_HOST: 'http://localhost' | |||
|
|
|||
| EXTRA_RUN_ARGS: '-Pprovisioned-server -DpostgresqlUsername="test" -DpostgresqlPassword="test"' | |||
There was a problem hiding this comment.
-Pprovisioned-server as a run arg looks weird, may come back after checking the QS changes
| @@ -132,7 +133,9 @@ jobs: | |||
| WildFly-build: | |||
| uses: wildfly/wildfly/.github/workflows/shared-wildfly-build.yml@main | |||
| with: | |||
| wildfly-branch: ${{ github.base_ref }} | |||
| # There is no upstream glow-preview branch. The QS glow-preview branch targets WildFLy main | |||
There was a problem hiding this comment.
I think now should be reverted?
.github/workflows/reduce_readme.yml
Outdated
| @@ -3,7 +3,7 @@ name: WildFly Quickstarts Update 'README.adoc's | |||
| on: | |||
| push: | |||
| branches: | |||
| - main | |||
| - glow-preview | |||
There was a problem hiding this comment.
I think now should be reverted?
README.adoc
Outdated
| @@ -62,7 +62,7 @@ ifndef::ProductRelease,EAPXPRelease[] | |||
| :productImageVersion: 31.0 | |||
| :githubRepoUrl: https://github.com/wildfly/quickstart/ | |||
| :githubRepoCodeUrl: https://github.com/wildfly/quickstart.git | |||
| :WildFlyQuickStartRepoTag: 31.0.0.Final | |||
| :WildFlyQuickStartRepoTag: 31.0.0.Final-glow-preview | |||
There was a problem hiding this comment.
Please note that any change in README.adoc that was not auto done by the asciidoc-reducer should be moved to related README-source.adoc . I think you should confirm this, and revert all README.adoc
I guess those portedToGlow should now be removed and the shared-docs include file should be updated, wrt the XML snippet change for both server provisioning and bootable jar
…ests against built server
Copy the meat of the poms from the current upstream/glow-preview branch
This reverts commit 54b647d.
|
@kabir: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.