Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFARQ-121] Rename the socketBindingGroup property to socketBindingName. #241

Merged
merged 1 commit into from
Nov 4, 2022
Merged

[WFARQ-121] Rename the socketBindingGroup property to socketBindingName. #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions common/src/main/java/org/jboss/as/arquillian/container/CommonContainerConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class CommonContainerConfiguration implements ContainerConfiguration {
private String protocol = "http";
private String host;
private int port;
private String socketBindingGroup;
private String socketBindingName;

/**
* Optional connection timeout in millis.
Expand Down Expand Up @@ -115,8 +115,8 @@ public void setProtocol(final String protocol) {
*
* @return the socket binding name or {@code null} to discover one
*/
public String getSocketBindingGroup() {
return socketBindingGroup;
public String getSocketBindingName() {
return socketBindingName;
}

public String getHost() {
Expand Down Expand Up @@ -181,8 +181,8 @@ public void setAuthenticationConfig(final String authenticationConfig) {
*
* @param socketBindingName the socket binding name or {@code null} for one to be determined
*/
public void setSocketBindingGroup(final String socketBindingName) {
this.socketBindingGroup = socketBindingName;
public void setSocketBindingName(final String socketBindingName) {
this.socketBindingName = socketBindingName;
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions common/src/main/java/org/jboss/as/arquillian/container/ManagementClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,8 @@ public Object run() {
} catch (URISyntaxException e) {
throw new RuntimeException(e);
}
if (config != null && config.getSocketBindingGroup() != null) {
webUri = getBinding(config.getSocketBindingGroup());
if (config != null && config.getSocketBindingName() != null) {
webUri = getBinding(config.getSocketBindingName());
} else {
if (undertowSubsystem != null && undertowSubsystem.hasDefined("server")) {
List<Property> vhosts = undertowSubsystem.get("server").asPropertyList();
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/junit5-tests/src/test/resources/override-web-uri-arquillian.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<property name="javaVmArguments">${debug.vm.args} ${jvm.args}</property>
<property name="allowConnectingToRunningServer">false</property>
<property name="protocol">https</property>
<property name="socketBindingGroup">https</property>
<property name="socketBindingName">https</property>
</configuration>
</container>
</arquillian>