Add system property for setting read only server config #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this change to Wildfly core wildfly/wildfly-core@a958b5e Driven by this issue https://issues.redhat.com/browse/WFCORE-5792 A server config file that is stored outside of the managed Wildfly server's configuration directory can no longer be provided via the jboss.server.config.file.name system property. A read-only server config must be used if the config file is outside the configuration directory. This is problematic if, for example, one keeps a test server config file under version control in a project's test resources directory while having the managed Wildfly instance outside of the code base, and one wants to continue to utilize system properties to set the server config. Setting the server config, regardless of location, via a system property is highly convenient and flexible. This change maintains that ability by the introduction of an additional system property named jboss.server.config.file.name.readonly that sets the read-only server config allowing server config files outside of the server configuration directory to be specified via a system property.
jamezp
approved these changes
May 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change to Wildfly core
wildfly/wildfly-core@a958b5e
Driven by this issue
https://issues.redhat.com/browse/WFCORE-5792
A server config file that is stored outside of the managed Wildfly server's configuration directory can no longer be provided via the jboss.server.config.file.name system property. A read-only server config must be used if the config file is outside the configuration directory.
This is problematic if, for example, one keeps a test server config file under version control in a project's test resources directory while having the managed Wildfly instance outside of the code base, and one wants to continue to utilize system properties to set the server config. Setting the server config, regardless of location, via a system property is highly convenient and flexible. This change maintains that ability by the introduction of an additional system property named jboss.server.config.file.name.readonly that sets the read-only server config allowing server config files outside of the server configuration directory to be specified via a system property.