Fix for WFCORE-6747, Upgrade to Galleon 6.0.0.Beta4 and WFGP 7.0.0.Beta5 #5907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
bstansberry
reviewed
Mar 19, 2024
| @@ -233,6 +233,8 @@ | |||
| <fork-embedded>${galleon.fork.embedded}</fork-embedded> | |||
| <generate-channel-manifest>true</generate-channel-manifest> | |||
| <minimum-stability>experimental</minimum-stability> | |||
| <config-stability>community</config-stability> | |||
| <package-stability>experimental</package-stability> | |||
There was a problem hiding this comment.
@jfdenise In a future iteration these 3 flags seem like things that should be part of wildfly-feature-back-build.xml.
The mojo options can remain as overrides (and for compatibility), but the other file seems like the right place for configuring the FP content, as opposed to the tool.
There was a problem hiding this comment.
@bstansberry , thank-you I logged https://issues.redhat.com/browse/WFGP-275 to track it.
bstansberry
approved these changes
Mar 19, 2024
|
Thanks @jfdenise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFCORE-6747
Align with Stability handling in provisioning as specified in wildfly/wildfly-proposals#555