Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-7033] signature verification #6222

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

spyrkob
Copy link
Contributor

@spyrkob spyrkob commented Oct 17, 2024

@spyrkob
Copy link
Contributor Author

spyrkob commented Oct 17, 2024

@yersan this is not a complete PR yet, but could you take a quick look at this and let me know if you're happy with this approach?

@wildfly-ci
Copy link

Core -> Full Integration Build 14286 outcome was FAILURE using a merge of 0154a29
Summary: Exit code 1 (Step: Build core (Maven)) (new) Build time: 00:01:57

@wildfly-ci
Copy link

Core -> Full Integration Build 13992 outcome was FAILURE using a merge of 0154a29
Summary: Exit code 1 (Step: Build core (Maven)) (new) Build time: 00:01:25

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14063 outcome was FAILURE using a merge of 0154a29
Summary: Exit code 1 (Step: Build core (Maven)) (new) Build time: 00:01:50

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14072 outcome was FAILURE using a merge of 2106ab7
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:35

@wildfly-ci
Copy link

Core -> Full Integration Build 13999 outcome was FAILURE using a merge of 2106ab7
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:39

@wildfly-ci
Copy link

Core -> Full Integration Build 14293 outcome was FAILURE using a merge of 2106ab7
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:47

@yersan yersan added Feature This PR adds a new feature to WildFly missing-reqs This PR is missing external requirements before it can be merged labels Oct 23, 2024
Copy link
Collaborator

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments with a quick look, I have not played with this yet, but overall approach looks good

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14085 outcome was FAILURE using a merge of 673d837
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:10

@wildfly-ci
Copy link

Core -> Full Integration Build 14306 outcome was FAILURE using a merge of 673d837
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:33

@wildfly-ci
Copy link

Core -> Full Integration Build 14012 outcome was FAILURE using a merge of 673d837
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:47

@spyrkob spyrkob force-pushed the WFCORE-7033_signature-verification branch from 673d837 to 3158ecd Compare October 29, 2024 15:59
@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14086 outcome was FAILURE using a merge of 3158ecd
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:00:58

@wildfly-ci
Copy link

Core -> Full Integration Build 14307 outcome was FAILURE using a merge of 3158ecd
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:25

@wildfly-ci
Copy link

Core -> Full Integration Build 14013 outcome was FAILURE using a merge of 3158ecd
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:01:33

@spyrkob
Copy link
Contributor Author

spyrkob commented Oct 29, 2024

Thanks @yersan! I updated the PR with your comments and made a few changes to work with the Web Console a bit easier. I'll create the wildfly-proposal and mark this as ready for review when that's ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR adds a new feature to WildFly missing-reqs This PR is missing external requirements before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants