Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-13023] Upgrade MicroProfile Config 1.4 #285

Conversation

jmesnil
Copy link
Member

@jmesnil jmesnil commented Feb 4, 2020

@jmesnil jmesnil force-pushed the WFLY-13023_upgrade_microprofile-config_1.4 branch from 8761b21 to c8b27d1 Compare February 4, 2020 09:48
@jmesnil jmesnil force-pushed the WFLY-13023_upgrade_microprofile-config_1.4 branch from c8b27d1 to dcf9854 Compare February 10, 2020 09:57

* Run the WildFly integration basic test suite and checks there are no failures related to MicroProfle Config tests.
* Run the `microprofile-tck/config` module from WildFly integration test suite and checks that there are no failures.
* Some tests that relates to the https://github.com/eclipse/microprofile-config/issues/446[inconsistent behaviour for empty/missing config property (#446)] are excluded as smallrye-config implementation does not pass the TCK tests that are challenged by this issue.
Copy link

@marekkopecky marekkopecky Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smallrye-config implementation does not pass the TCK tests

@jmesnil Can you please share more details about this? Which tests doesn't pass? I don't see any ignored tests in WF TS. Does this means that new SmallRye Config 1.6.1 is not compliant with MP Config 1.4?

Some tests that relates to the https://github.com/eclipse/microprofile-config/issues/446[inconsistent behaviour for empty/missing config property (#446)] are excluded ...

Can you please share list of these tests?

eclipse/microprofile-config#446

I'm looking to this issue and it seems that there is no conclusion about future behaviour.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marekkopecky, test excluded from the MP config TCK are configured in https://github.com/wildfly/wildfly/blob/3af5d5438457bc2697ffc59118e7d5ce247f875d/testsuite/integration/microprofile-tck/config/tck-suite.xml#L11

The discussion in eclipse/microprofile-config#446 is ongoing will not be resolved before MP Config 2.0 is released

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check WF TS and SmallRye TS (1.6.1). Excluded TCK tests fails in both these TSs

@jmesnil jmesnil force-pushed the WFLY-13023_upgrade_microprofile-config_1.4 branch from dcf9854 to 5d9e1db Compare February 12, 2020 13:26
@marekkopecky
Copy link

@jmesnil Thank you for your updates.

@bstansberry bstansberry merged commit c86beb4 into wildfly:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants