[WFLY-13412]:Add_Json_Merge_Patch_support

[jimma]

No description provided.

[honza-kasik]

This analysis should include the fact that we need to backport the feature as per https://issues.redhat.com/browse/RESTEASY-2567 since now it reads that no work is needed.

[jimma]

This is already included in 3.15.9.Final. There is no work is needed for EAP.

[honza-kasik]

@jimma My bad, I see the test now in 3.15 branch https://github.com/resteasy/resteasy/blob/3.15/testsuite/integration-tests/src/test/java/org/jboss/resteasy/test/resource/patch/StudentPatchTest.java So the https://issues.redhat.com/browse/RESTEASY-2567 is outdated?

[jimma]

Sorry, my mistake. Checked it again and json merge patch isn't backported in 3.15.x, but this is already included since 4.1.x , should be already included in EAP8 and no work is need for EAP8.

[emmartins]

@jimma the analysis doesn't include the sections regarding configuration and deployment, I am assuming this means that this new feature has no side effects on old server configs, and require no changes to be done by customers in their apps, when they migrate...

Can you please confirm my analysis of zero migration impact is correct?

[honza-kasik]

@jimma Per @jamezp comment on the product tracker, this analysis needs to state which JSON provider is this RFE targeting. And if it targets non-default JSON provider, it should explain the reason.

[jimma]

@honza-kasik It looks Resteasy AbstractPatchMethodFilter handles this correctly. By default, it uses Jakarta JSON Processing PATCH filter to handle json patch and json merge patch request. The Jackson PATCH filter is only enabled when user sets the RESTEASY_PATCH_FILTER_LEGACY parameter to true.

https://github.com/resteasy/resteasy/blob/6.2.10.Final/resteasy-core/src/main/java/org/jboss/resteasy/plugins/providers/AbstractPatchMethodFilter.java#L44-L72

[honza-kasik]

Thanks @jimma ! Can this mention about the parameter be added to this document please?

[jimma]

@honza-kasik I already added to this document, please have a look.

[jimma]

@jimma the analysis doesn't include the sections regarding configuration and deployment, I am assuming this means that this new feature has no side effects on old server configs, and require no changes to be done by customers in their apps, when they migrate...

Can you please confirm my analysis of zero migration impact is correct?

@emmartins Yes, I confirmed and there is no migration impact.

[emmartins]

@jimma got it, thanks

[honza-kasik]

Thanks, this looks good from QE PoV

[jamezp]

This needs to be migrated to the new format defined in https://github.com/wildfly/wildfly-proposals/blob/main/design-doc-template.adoc?plain=1.

It will also need to follow the new process defined in https://github.com/wildfly/wildfly-proposals/blob/main/FEATURE_PROCESS.adoc.

[jimma]

@jamezp Updated this PR. Thanks for review.

[jamezp]

We should ensure all the references to JSON are referenced as "JSON" all caps. We should be referencing RESTEasy in all cases too. There is currently a mix of cases for RESTEasy.

[jamezp]

We should only discuss the Jakarta JSON Processing option IMO. We shouldn't mention the legacy option.

[jimma]

This is requested by @honza-kasik, as this is still there and still can be set to switch.

[jamezp]

Sorry about these additional changes. I wasn't able to locally render this site with Jekyll before and I was finally able to figure out how to get it to work.

[jamezp]

Just noticed the file name includes "EAP7-1494", that should be removed. It should also probably be renamed to something like WFLY-19981_Json_Merge_Patch_suppoert.adoc.

[jimma]

@jamezp Change are squashed. Please review and merge. Thanks.