Update template and checks #581
Conversation
jmesnil
force-pushed
the
issue_stability_level_checks
branch
from
af28396 to
98c4b6c
Compare
jmesnil
force-pushed
the
issue_stability_level_checks
branch
from
98c4b6c to
0824288
Compare
jmesnil
force-pushed
the
issue_stability_level_checks
branch
from
daf030d to
c2fea16
Compare
jmesnil
force-pushed
the
issue_stability_level_checks
branch
5 times, most recently
from
bd003b7 to
7822862
Compare
* Update the template to move the tracking issue and the stability level to the front matter * When a PR is open, check that these fields are valid * Generate a HTML page for the proposal with these fields. Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Based on the value of the `stability-level` field in the front matter, add a label `stability-level/xxx` to the PR. Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jmesnil
force-pushed
the
issue_stability_level_checks
branch
from
7822862 to
caae72f
Compare
There was a problem hiding this comment.
Hi @jmesnil -- I have a couple requests.
For context around these requests please have a look at https://docs.google.com/document/d/1e2hCAb--ApK32fPbUTWQSn6fH9GqmqZuaUPYwIp01JQ/edit. That's a draft of an email I plan to send to wildfly-dev once we merge this.
* bring back Related Issues sections * clarify the issue metadata semantic Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
|
@bstansberry I've updated the PR and made some suggestions to the mail you will send. thanks! |
|
I've created the labels that will be added to the PR based on their stability-level attributes:
|
|
@bstansberry Could we also merge #584? It would unclutter the PR queue. |
|
Thanks @jmesnil |
This PR updates the template to be more descriptive about its expected content.
As a demo, I opened a "dummy" proposal in my fork that was missing the
issueandstability-levelin the front matter:missing-issueandinvalid-stability-levellabels were automatically added to the PRstability-levelfield is valid in the front matter, add a label to the GitHub PR of the formstability-level/XXX(as seen on my fork at New feature jmesnil/wildfly-proposals#15)Before that PR is merged, the following labels must be created:
missing-issue- The analysis document is missing an issue tracker in its metadatainvalid-stability-level- The analysis document is missing a valid stability level in its metadatastability-level/experimental- Feature is at the "Experimental" stability levelstability-level/preview- Feature is at the "Preview" stability levelstability-level/community- Feature is at the "Community" stability levelstability-level/default- Feature is at the "Default" stability level