[Issue_668] Jakarta Data blog post #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstansberry
force-pushed
the
Issue_668
branch
2 times, most recently
from
f60be93 to
449d4f0
Compare
yrodiere
reviewed
Oct 11, 2024
_posts/2024-10-10-jakarta-data.adoc
Outdated
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.12.0</version> <!-- 3.12 or later is necessary for proper dependency management in annotationProcessorPaths --> |
There was a problem hiding this comment.
Might as well recommend the latest 3.12 while you're at it; 3.12.0 had some rather annoying issues that did impact other projects: https://issues.apache.org/jira/browse/MCOMPILER-567
Suggested change
| <version>3.12.0</version> <!-- 3.12 or later is necessary for proper dependency management in annotationProcessorPaths --> | |
| <version>3.12.1</version> <!-- 3.12 or later is necessary for proper dependency management in annotationProcessorPaths --> |
_posts/2024-10-10-jakarta-data.adoc
Outdated
| ---- | ||
|
|
||
|
|
||
| WARNING: Some users may have learned to configure Hibernate annotation processing by declaring `org.hibernate.orm:hibernate-jpamodelgen` as a `provided` dependency in their pom. With the Hibernate version used with WildFly, link:https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.7#jpamodelgen[this will likely fail, window=_blank]. Use the `maven-compiler-plugin` configuration approach described above. |
There was a problem hiding this comment.
Alternative link that does not involve Quarkus: https://docs.jboss.org/hibernate/orm/6.3/migration-guide/migration-guide.html#metamodel-generation
Suggested change
| WARNING: Some users may have learned to configure Hibernate annotation processing by declaring `org.hibernate.orm:hibernate-jpamodelgen` as a `provided` dependency in their pom. With the Hibernate version used with WildFly, link:https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.7#jpamodelgen[this will likely fail, window=_blank]. Use the `maven-compiler-plugin` configuration approach described above. | |
| WARNING: Some users may have learned to configure Hibernate annotation processing by declaring `org.hibernate.orm:hibernate-jpamodelgen` as a `provided` dependency in their pom. With the Hibernate version used with WildFly, link:https://docs.jboss.org/hibernate/orm/6.3/migration-guide/migration-guide.html#metamodel-generation[this will likely fail, window=_blank]. Use the `maven-compiler-plugin` configuration approach described above. |
bstansberry
force-pushed
the
Issue_668
branch
from
449d4f0 to
00392e4
Compare
|
Thanks for the quick review @yrodiere! I made your suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #668