-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecoscope 197 #245
Ecoscope 197 #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidovichmarcos thanks so much for getting this so close, overall looks great.
I did take the somewhat "extreme" stance of setting this review as "Request changes" because there are a few things that I think we should clean up here before merge.
In addition to the comments below, I think we should rename _tests.yml
to something like notebook-tests.yml
which is (a) more descriptive; and (b) doesn't start with underscore (because it is running directly, not being inherited).
Let me know if I can clarify anything. Again, amazing work, this will be a huge leap forward here! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sorting this out @davidovichmarcos 🙏
The only thing I'd add in addition to the credentials configuration is a preference to to make this more aligned with the existing workflows which have an environment.yaml
/ micromamba
setup, rather than requirements.txt
As I was writing this I realised we probably want to do away with both of these approaches and do something simpler per the CI in ecoscope-workflows
. Have created #247 to track that and leaving this here just to complete the loop. No action required here from you @davidovichmarcos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!!!
Now that we have mapping deps coming from ecoscope directly, I don't think we need folium and branca (see below).
Co-authored-by: Charles Stern <62192187+cisaacstern@users.noreply.github.com>
🚀 👏 |
Adding tests to execute notebooks with papermill on the CI