Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a general bar plot chart #416

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a general bar plot chart #416

wants to merge 1 commit into from
+61 −0

Conversation

Yun-Wu
Copy link
Contributor

@Yun-Wu Yun-Wu commented Feb 13, 2025 •
edited
Loading

Closes #418

@Yun-Wu Yun-Wu changed the title Add bar plot Add a general bar plot chart Feb 13, 2025
atmorling
atmorling requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@atmorling atmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as request changes because I think if the 3 lists must always be the same length then enforcing some kind of dataclass/tuple structure is preferred

ecoscope/plotting/plot.py
Comment on lines +345 to +347
columns: list[str],
agg_funcs: list[str],
labels: list[str],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should always have the same length no?
Would it make sense to make this triplet a dataclass and then have a single arg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmorling atmorling atmorling requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a general bar plot chart
2 participants
@Yun-Wu @atmorling