-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title bar visible after starting an application maximized #2
Comments
👍 |
I can reproduce this issue (with most applciations) - I shall fix it when I have time |
I have almost the same bug--for me the title bar just appears black on apps launched fullscreen--and un- then re-maximizing it also fixes for me. I'm using Gnome Shell 3.14.1.5. |
I think I'm having a similar issue. For me, when I'm running a maximized app, then suspend and wake up my computer, the formerly maximized app appears with a black bar at the top of the screen where the title bar would have been. Unmaximizing and remaximizing it fixes it, but it's annoying to have to do that every time. |
I also have the same problem with chromium and firefox and others, however it works fine with gnome apps like gedit, gnome-terminal....Hope you fix that soon, Anyways thanks for the amazing extension.. GNOME Shell 3.14.1.5 (Arch Linux 3.17.2-1-ARCH) |
affecting me as well, ubuntu 14.10 GNOME Shell 3.14.1 |
Affecting me too. Debian 8 (testing), gnome shell 3.14.1. I see black title bars on newly opened maximised windows. Hit alt-f10-f10 and the black bar disappears. |
Same here. For some windoes this is reproducible if I maximze then lock screen and then unlock. Result is black titlebar. |
Fedora 21, gnome-shell 3.14.2, same as #13. Need to press M-down and M-up to restore state of the window after screenlock. |
I think this issue can be fixed with an ugly hack using wmctrl |
@muhammedabuali can you post your ugly hack here? I'll be glad to try it out. |
@ronjouch sure. with wmctrl given the id of the window we can make it full screen and not full screen later so it will appear normal FLAG=1 ;\
ID=$(xprop -root 32x '\t$0' _NET_ACTIVE_WINDOW | cut -f 2);\
xprop -id $ID -f _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED 32c -set _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED $FLAG;\
wmctrl -i -r $ID -b add,fullscreen ;\
sleep 0.01 ;\
wmctrl -i -r $ID -b remove,fullscreen |
to apply this hack :
go to the line 125 and insert after it the following let cmd_full = ['wmctrl', '-i', '-r' , id , '-b', 'add,fullscreen'];
let sleep_time = '0.01'
let cmd_sleep = ['sleep', sleep_time];
let cmd_unfull = ['wmctrl', '-i', '-r' , id , '-b', 'remove,fullscreen'];
Util.spawn(cmd_full);
Util.spawn(cmd_sleep);
Util.spawn(cmd_unfull); |
@muhammedabuali thanks for sharing your patch! Just tried it, but on my 4-years-old laptop, it yields irregular results:
I tried fiddling with the |
I haven't encountered the second case on my machine |
I think this works out better add this to the constants in the start of the decoration.js file const MAXIMIZED = (Meta.MaximizeFlags.HORIZONTAL | Meta.MaximizeFlags.VERTICAL); and replace the older snippet with this one if (hide) {
let cmd_toggle = ['wmctrl', '-i', '-r' , id , '-b', 'toggle,maximized_vert,maximized_horz'];
let cmd_full = ['wmctrl', '-i', '-r' , id , '-b', 'add,maximized_vert,maximized_horz'];
if (win.get_maximized() === MAXIMIZED && !win.minimized) {
Util.spawn(cmd_toggle);
Util.spawn(cmd_toggle);
Util.spawn(cmd_full);
}
} |
@muhammedabuali cool, this second approach seems to work more frequently (I'd say ~80% on my machine). However, once in a while I end up in one of two failure states: a. displaying the black titlebar, or b. window ending up appearing unmaximized (windowed). Leaving it activated and trying to fiddle with it. |
nice idea - I will try having a fiddle around as well and see if it improves anything or can be improved. |
@wilfm I run GNOME 3.16 on Archlinux under Wayland, it works with @muhammedabuali 's patch |
Seems to fix the bug where a black bar would sometimes replace the title bar.
Probably the issues fixed for current versions with updates, but once I have sorted out documentation, other pull requests etc I'll make a few development versions available with interesting fixes like this. |
Am running v5 from the github releases zip, indeed it looks fixed 👍 |
I have this issue with latest version on extensions.gnome.org, is that an older version than the one here? |
I'm using Ubuntu Gnome 14.10 with GNOME Shell 3.12.2.
The extension works well if I maximize or minimize a running application window - but if an application starts maximized, the title bar remains visible (but you can't use the minimize/maximize/close buttons on it).
Minimizing and maximizing the window hides the title bar, but it's annoying to do that every time the application starts...
The text was updated successfully, but these errors were encountered: