[WIP] adding support for OIDC, rebase to current master of django-oauth-toolkit #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enID parameters to oauthlib.common.Request
…e to avoid validation security breach
* according to [`oauthlib` 3.0.0](/oauthlib/oauthlib/releases/tag/v3.0.0), now it returns 400's instead of 401; * Python 2.7 support was dropped, fixed `urllib.parse` imports and missing `python_2_unicode_compatible` decorator.
This work is targeted primarily exactly to 3.0.0 in which OIDC is implemented.
wiliamsouza
force-pushed
the
openid-connect
branch
from
266ff15 to
0d3904a
Compare
|
Not the same like this django-oauth#545? Look the last commits. |
|
didn't see this before sorry. |
|
This was a PR to your fork, not jazzband's repo. It was an attempt to assist you in your work in order to speed up release of this feature because I'm very interested in it. Never mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
oauthlib3.0.0 finally arrives, so we can proceed.I rebased your PR to latest master of django-oauth-toolkit in order to speed up merging of this PR.
I also fixed some tests according to latest changes in
oauthlib- now it respond with 400 instead of 401 in some cases. Not sure that all fixes is appropriate, please review. I don't know thoroughly the specs.The full test suite still doesn't pass, though.