-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make treemapify compatible with plotly r package #40
Comments
@fernandovmacedo I'd be happy to help, but I'm not really familiar with plotly – what would be required at my end to make treemapify plotly-compatible? |
Hi @fernandovmacedo, @moutikabdessabour is looking into a converter here plotly/plotly.R#2051 As I pointed out here plotly/plotly.R#2051 (comment), some of the implementation borrows heavily from |
@cpsievert I'd be happy to sign a contributor agreement if that helps. Bob Rudis (@hrbrmstr) is also a listed author of treemapify and there are three other contributors to the package, so I assume at least Bob would have to sign too. For what it's worth, the only section of the pull request that strikes me as being lifted from treemapify is lines 706–713 of R/layers2traces.R, which probably deserve to be refactored anyway. |
I can def sign as well.
…On Mon, Nov 15, 2021 at 01:27 David Wilkins ***@***.***> wrote:
@cpsievert <https://github.com/cpsievert> I'd be happy to sign a
contributor agreement if that helps. Bob Rudis ***@***.***
<https://github.com/hrbrmstr>) is also a listed author of treemapify and
there are three other contributors to the package, so I assume at least Bob
would have to sign too.
For what it's worth, the only section of the pull request
<https://github.com/plotly/plotly.R/pull/2051/files> that strikes me as
being lifted from treemapify is lines 706–713 of R/layers2traces.R, which
probably deserve to be refactored anyway.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD4PNX4HN34JDSEC5GKGSDUMCR3ZANCNFSM4NO2CFCQ>
.
|
Adding treemapify is already a plotly issue, but I think it will take a long time. So also adding here to see if the author is willing to help there.
The text was updated successfully, but these errors were encountered: