Fix the loading of the Intl JS polyfills #363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Intl polyfill has been split into dedicated polyfills in 2020. As the Cloudflare service allows to specify a version of the polyfill-library, the version is now locked to avoid being affected by such change again.
|
hmm, apparently, this is not enough. It looks like the polyfill service decides that Intl is supported by the browser. Maybe phantomjs is not detected properly. |
|
Given that phantomjs is dead, I will submit a PR replacing the JS test runner instead (which might remove the need for polyfills entirely thanks to having native Intl support) |
|
Closing in favor of #367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Intl polyfill has been split into dedicated polyfills in 2020.
As the Cloudflare service allows to specify a version of the polyfill-library, the version is now locked to avoid being affected by such change again.