Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doctrine/annotations:2 #327

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Allow doctrine/annotations:2 #327

merged 3 commits into from
Jan 31, 2023

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Jan 27, 2023

No description provided.

@goetas
Copy link
Collaborator

goetas commented Jan 27, 2023

could you please fix the CI?

@goetas
Copy link
Collaborator

goetas commented Jan 28, 2023

something is wrong with doctrine annotations 2.0. all the tests with it are failing , see https://github.com/willdurand/Hateoas/actions/runs/4025499234/jobs/6918796248

@W0rma
Copy link
Contributor Author

W0rma commented Jan 30, 2023

could you please fix the CI?

#328 tries to fix the CI in master. I'm going to rebase this PR afterwards.

@goetas goetas closed this Jan 30, 2023
@goetas goetas reopened this Jan 30, 2023
@goetas
Copy link
Collaborator

goetas commented Jan 30, 2023

merged #328

@W0rma
Copy link
Contributor Author

W0rma commented Jan 31, 2023

Rebased. This PR is now ready for review.

@goetas goetas merged commit 39bae03 into willdurand:master Jan 31, 2023
@goetas
Copy link
Collaborator

goetas commented Jan 31, 2023

looks good, thanks!

@W0rma W0rma deleted the annotations-2 branch January 31, 2023 15:11
@W0rma
Copy link
Contributor Author

W0rma commented Feb 13, 2023

@goetas Do you plan to tag a new patch release?

@SVillette
Copy link

Hi @goetas and @W0rma,

Any news about releasing a new version ?
This library is the missing piece for an upgrade to doctrine/annotations:^2.0 in my projects.

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants