add the files operation to slackpkg #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will fix #28. A big ty to Will and gk, who implemented slacklist().
|
A big ty to Will and gk, who implemented slacklist().
I didn't do anything but I'll take the undeserved credit lol
|
|
you were there when it happened, and made suggestions |
eepykate
reviewed
Oct 21, 2021
eepykate
reviewed
Oct 21, 2021
eepykate
suggested changes
Oct 21, 2021
|
im going to try to put in a bit more work to make it moreso agnostic, but just to let you know, @6gk, i've implimented your suggestions. |
|
:yesyes:
and i wish i were @gk :(
github hates me :((((((((((
(jk obviously, their reasons were fair)
|
ty @6gk for the suggestions
|
lmao |
eepykate
suggested changes
Oct 21, 2021
update comment haha have fun squashing this on pr
willeccles
requested changes
Oct 21, 2021
|
that should do it; @willeccles: any other requests/wishes/formatting you want? |
|
See my comment on the last review; it's broken right now. |
willeccles
requested changes
Oct 21, 2021
willeccles
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will fix #28. A big ty to Will and gk, who implemented slacklist().