Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nix support #47

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Remove nix support #47

merged 2 commits into from
Oct 22, 2021

Conversation

willeccles
Copy link
Owner

@willeccles willeccles commented Oct 22, 2021

Nix is not supposed to be used on NixOS the way that cpm implements it,
and it's (to the best of my knowledge) not the best way on other
platforms as well. We also do not support non-platform-specific package
managers, so the precedent says we should remove this one.

Nix is not supposed to be used on NixOS the way that cpm implements it,
and it's (to the best of my knowledge) not the best way on other
platforms as well. We also do not support non-platform-specific package
managers, so the precedent says we should remove this one.
@willeccles willeccles added the enhancement New feature or request label Oct 22, 2021
@willeccles
Copy link
Owner Author

@6gk and @buffet, thoughts?

@willeccles
Copy link
Owner Author

Also, input from @mlvzk would be appreciated.

@foxsouns foxsouns mentioned this pull request Oct 22, 2021
@eepykate
Copy link
Contributor

not the best way on other platforms as well.

Hence why it's at the bottom.

I dunno, I like having it as a fallback, especially coupled with pm=nix cpm i nixpkgs.bad existing.

Admittedly I haven't touched nix in ages and my nix PM install is broke so take that with a grain of salt.

@foxsouns
Copy link
Contributor

maybe as a middle ground we could have nix as an explicit only thing
like it only runs if pm=nix, and maybe have a message saying on firstrun "the nix implementation here is not to spec, and is not supported."

@willeccles
Copy link
Owner Author

maybe as a middle ground we could have nix as an explicit only thing like it only runs if pm=nix, and maybe have a message saying on firstrun "the nix implementation here is not to spec, and is not supported."

This would require adding logic that is not used for any other package manager, and it wouldn't make much sense to have a special case for this.

@foxsouns
Copy link
Contributor

fair

@eepykate
Copy link
Contributor

But yeah, as I said, I haven't used nix in like 5 months (last time was helping ladle with something iirc?) & I've never used it in cpm.

Sooo major grain of salt there lmao.

I don't have anything against removing it, of course, i just kinda like having it as a potential fallback.

@willeccles
Copy link
Owner Author

I think since @buffet approved it and is probably the most experienced with nix by a wide margin, I'll go ahead and merge.

@willeccles willeccles merged commit 57710f0 into master Oct 22, 2021
@willeccles willeccles deleted the rmnix branch October 22, 2021 15:08
@eepykate
Copy link
Contributor

eepykate commented Oct 22, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants