Skip to content

Commit

Permalink
Fix imports for coord_geo_polar and coord_geo_radial
Browse files Browse the repository at this point in the history
  • Loading branch information
willgearty committed Sep 20, 2024
1 parent 41fc3dd commit 7e4ea44
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
2 changes: 2 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ importFrom(ggplot2,calc_element)
importFrom(ggplot2,coord_cartesian)
importFrom(ggplot2,coord_flip)
importFrom(ggplot2,coord_polar)
importFrom(ggplot2,coord_radial)
importFrom(ggplot2,coord_trans)
importFrom(ggplot2,discrete_scale)
importFrom(ggplot2,draw_key_pointrange)
Expand All @@ -86,6 +87,7 @@ importFrom(ggplot2,scale_fill_identity)
importFrom(ggplot2,scale_fill_manual)
importFrom(ggplot2,scale_x_continuous)
importFrom(ggplot2,scale_x_reverse)
importFrom(ggplot2,scale_y_continuous)
importFrom(ggplot2,set_last_plot)
importFrom(ggplot2,standardise_aes_names)
importFrom(ggplot2,theme_void)
Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# deeptime (development version)

* Fixed importing some functions from ggplot2 for coord_geo_radial and coord_geo_polar

# deeptime 2.0.0
__deeptime now requires ggplot2 version 3.5.0 or higher__.\
This new major version of deeptime includes several new features:
Expand Down
4 changes: 2 additions & 2 deletions R/coord_geo_polar.R
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,8 @@ clean_dat <- function(dat, fill, neg, r_lims) {
#' @export
#' @importFrom ggplot2 ggproto CoordPolar ggproto_parent coord_polar theme_void
#' @importFrom ggplot2 geom_vline geom_rect geom_segment
#' @importFrom ggplot2 scale_x_continuous scale_fill_manual calc_element
#' @importFrom ggplot2 last_plot set_last_plot
#' @importFrom ggplot2 scale_x_continuous scale_y_continuous scale_fill_manual
#' @importFrom ggplot2 last_plot set_last_plot calc_element
#' @importFrom grid addGrob reorderGrob grid.ls
#' @importFrom rlang %||% exec
CoordGeoPolar <- ggproto("CoordGeoPolar", CoordPolar,

Check warning on line 244 in R/coord_geo_polar.R

View workflow job for this annotation

GitHub Actions / lint

file=R/coord_geo_polar.R,line=244,col=1,[object_name_linter] Variable and function name style should match snake_case or symbols.
Expand Down
6 changes: 3 additions & 3 deletions R/coord_geo_radial.R
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,10 @@ coord_geo_radial <- function(dat = "periods",
#' @format NULL
#' @usage NULL
#' @export
#' @importFrom ggplot2 ggproto ggproto_parent coord_polar theme_void
#' @importFrom ggplot2 ggproto ggproto_parent coord_radial theme_void
#' @importFrom ggplot2 geom_vline geom_rect geom_segment CoordRadial
#' @importFrom ggplot2 scale_x_continuous scale_fill_manual calc_element
#' @importFrom ggplot2 last_plot set_last_plot
#' @importFrom ggplot2 scale_x_continuous scale_y_continuous scale_fill_manual
#' @importFrom ggplot2 last_plot set_last_plot calc_element
#' @importFrom grid addGrob reorderGrob grid.ls
#' @importFrom rlang %||% exec
CoordGeoRadial <- ggproto("CoordGeoRadial", CoordRadial,

Check warning on line 158 in R/coord_geo_radial.R

View workflow job for this annotation

GitHub Actions / lint

file=R/coord_geo_radial.R,line=158,col=1,[object_name_linter] Variable and function name style should match snake_case or symbols.
Expand Down

0 comments on commit 7e4ea44

Please sign in to comment.