Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename server_configurations -> configs #468

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

mehalter
Copy link
Contributor

@mehalter mehalter commented Oct 1, 2024

A couple hours ago nvim-lspconfig just did a big refactor that renames the server_configurations modules to configs: neovim/nvim-lspconfig#3330

This applies the rename here so that mason-lspconfig still functions. It is worth noting that require("lspconfig.configs") is still the same as before, it's just the default server configurations are now "lspconfig.configs.<server_name>".

Another small change was moving from :format() to string concatenation. This isn't a huge deal, but in Lua simple string concatenation is marginally faster than string format.

Once this is merged in it is probably a good idea to do a quick patch version release for people who are tracking official releases since this is a pretty big breaking change 😄

EDIT: Also applied changes necessary for other big changes/refactors in nvim-lspconfig in the past couple weeks. Total list of upstream PRs this takes into account:

Closes #469

@mehalter
Copy link
Contributor Author

mehalter commented Oct 1, 2024

neovim/nvim-lspconfig#3310

looks like als was also removed a couple weeks ago as well. I'll look into getting that resolved here as well.

@mehalter mehalter force-pushed the server_configurations_rename branch 3 times, most recently from 1630472 to 5e2098b Compare October 1, 2024 15:17
@mehalter
Copy link
Contributor Author

mehalter commented Oct 1, 2024

The only thing left to do here really is to decide if mason-lspconfig should also reflect these changes regarding server_configurations -> configs. I'll do a push with this refactor because I think over time it seems most logical to mirror the nvim-lspconfig structure, but if you want to keep it as before then I can easily revert that one change.

EDIT: I reverted this change because it completely broke the tests and I'm not familiar enough with the code base to identify the issue immediately. I'll leave applying that change to you if you want to mirror the upstream resolved

@mehalter mehalter force-pushed the server_configurations_rename branch 2 times, most recently from ff3c0db to cdea66f Compare October 1, 2024 15:29
@mehalter
Copy link
Contributor Author

mehalter commented Oct 3, 2024

@williamboman sorry for the extra ping, I just wanted to see if this could get reviewed. Especially with the new neovim version release today I suspect a lot of people might be updating their configurations and this plugin will stop working in some regards with the changes to lspconfig

@jack-obrien
Copy link

Also, all the links in README.md need to get updated to point towards configs.md instead of server_configurations.md

@mehalter
Copy link
Contributor Author

mehalter commented Oct 7, 2024

Also, all the links in README.md need to get updated to point towards configs.md instead of server_configurations.md

Don't worry, that's already done in this PR :)

@mehalter mehalter force-pushed the server_configurations_rename branch from 7e8ae5a to c86ea63 Compare October 7, 2024 12:14
@mehalter mehalter force-pushed the server_configurations_rename branch from 14089b9 to 7f0373b Compare October 7, 2024 12:24
Copy link
Owner

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for late review. I reverted the nvim 0.9.0 upgrade (which makes total sense, I'll add in a different PR for better changelog) and the mason-lspconfig module rename (I don't think this is necessary, might even be a breaking change to a handful users who override these modules).

@williamboman
Copy link
Owner

Oh nvim-lspconfig has a hard dependency on nvim 0.9, let me merge the nvim version requirement upgrade first and rebase

@mehalter
Copy link
Contributor Author

Thanks so much! Let me know if you want me to do anything else on this or if you want to handle the merging and stuff finishing up the rest of this. Glad to help contribute 😄

…_rename

* origin/main:
  fix: update required nvim version to >= 0.9.0 (williamboman#478)
@williamboman williamboman merged commit 87638e7 into williamboman:main Oct 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: nvim-lspconfig renamed server_configurations to configs
4 participants