-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename server_configurations
-> configs
#468
fix: rename server_configurations
-> configs
#468
Conversation
looks like |
1630472
to
5e2098b
Compare
The only thing left to do here really is to decide if
|
ff3c0db
to
cdea66f
Compare
@williamboman sorry for the extra ping, I just wanted to see if this could get reviewed. Especially with the new neovim version release today I suspect a lot of people might be updating their configurations and this plugin will stop working in some regards with the changes to lspconfig |
Also, all the links in README.md need to get updated to point towards configs.md instead of server_configurations.md |
Don't worry, that's already done in this PR :) |
7e8ae5a
to
c86ea63
Compare
14089b9
to
7f0373b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and sorry for late review. I reverted the nvim 0.9.0 upgrade (which makes total sense, I'll add in a different PR for better changelog) and the mason-lspconfig module rename (I don't think this is necessary, might even be a breaking change to a handful users who override these modules).
Oh nvim-lspconfig has a hard dependency on nvim 0.9, let me merge the nvim version requirement upgrade first and rebase |
Thanks so much! Let me know if you want me to do anything else on this or if you want to handle the merging and stuff finishing up the rest of this. Glad to help contribute 😄 |
…_rename * origin/main: fix: update required nvim version to >= 0.9.0 (williamboman#478)
A couple hours ago nvim-lspconfig just did a big refactor that renames the
server_configurations
modules toconfigs
: neovim/nvim-lspconfig#3330This applies the rename here so that
mason-lspconfig
still functions. It is worth noting thatrequire("lspconfig.configs")
is still the same as before, it's just the default server configurations are now"lspconfig.configs.<server_name>"
.Another small change was moving from
:format()
to string concatenation. This isn't a huge deal, but in Lua simple string concatenation is marginally faster than string format.Once this is merged in it is probably a good idea to do a quick patch version release for people who are tracking official releases since this is a pretty big breaking change 😄
EDIT: Also applied changes necessary for other big changes/refactors in
nvim-lspconfig
in the past couple weeks. Total list of upstream PRs this takes into account:nvim-lspconfig
since all the tests break. Once a v2.0 release is tagged here then people using an older version can simply use the last release here which also supports the last release ofnvim-lspconfig
with 0.7-0.8 supportCloses #469