feat(fetch): include mason.nvim version in User-Agent (#1362)

williamboman · Jun 21, 2023 · e706d30 · e706d30
1 parent f7f81ab
commit e706d30
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/lua/mason-core/fetch.lua b/lua/mason-core/fetch.lua
@@ -6,8 +6,9 @@ local log = require "mason-core.log"
 local platform = require "mason-core.platform"
 local powershell = require "mason-core.managers.powershell"
 local spawn = require "mason-core.spawn"
+local version = require "mason.version"
 
-local USER_AGENT = "mason.nvim (+https://github.com/williamboman/mason.nvim)"
+local USER_AGENT = ("mason.nvim %s (+https://github.com/williamboman/mason.nvim)"):format(version.VERSION)
 
 ---@alias FetchMethod
 ---| '"GET"'

diff --git a/tests/mason-core/fetch_spec.lua b/tests/mason-core/fetch_spec.lua
@@ -3,6 +3,7 @@ local fetch = require "mason-core.fetch"
 local match = require "luassert.match"
 local spawn = require "mason-core.spawn"
 local stub = require "luassert.stub"
+local version = require "mason.version"
 
 describe("fetch", function()
     it(
@@ -21,7 +22,9 @@ describe("fetch", function()
             assert.spy(spawn.curl).was_called(1)
             assert.spy(spawn.wget).was_called_with {
                 {
-                    "--header=User-Agent: mason.nvim (+https://github.com/williamboman/mason.nvim)",
+                    ("--header=User-Agent: mason.nvim %s (+https://github.com/williamboman/mason.nvim)"):format(
+                        version.VERSION
+                    ),
                     "--header=X-Custom-Header: here",
                 },
                 "-nv",
@@ -38,7 +41,9 @@ describe("fetch", function()
                 match.same {
                     {
                         "-H",
-                        "User-Agent: mason.nvim (+https://github.com/williamboman/mason.nvim)",
+                        ("User-Agent: mason.nvim %s (+https://github.com/williamboman/mason.nvim)"):format(
+                            version.VERSION
+                        ),
                     },
                     {
                         "-H",
@@ -79,7 +84,9 @@ describe("fetch", function()
 
             assert.spy(spawn.wget).was_called_with {
                 {
-                    "--header=User-Agent: mason.nvim (+https://github.com/williamboman/mason.nvim)",
+                    ("--header=User-Agent: mason.nvim %s (+https://github.com/williamboman/mason.nvim)"):format(
+                        version.VERSION
+                    ),
                 },
                 "-nv",
                 "-o",
@@ -95,7 +102,9 @@ describe("fetch", function()
                 match.same {
                     {
                         "-H",
-                        "User-Agent: mason.nvim (+https://github.com/williamboman/mason.nvim)",
+                        ("User-Agent: mason.nvim %s (+https://github.com/williamboman/mason.nvim)"):format(
+                            version.VERSION
+                        ),
                     },
                 },
                 "-fsSL",