feat(npm): add install_args option
#1581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amittamari
force-pushed
the
feat/npm-install-args
branch
from
650e7c3
to
ab4c73a
Compare
amittamari
force-pushed
the
feat/npm-install-args
branch
from
ab4c73a
to
58ae34d
Compare
|
Resolved conflicts |
devlopersabbir
approved these changes
Jan 9, 2024
|
@williamboman can you please give this one a review? 🙏🏻 It's a relatively small change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Rework of #1580)
Often, when I'm working, my npm registry is set to the work's registry, which sometimes causes npm installations in Mason to fail.
To overcome this, I added the option to provide
install_argsto npm, the same as available in pip, so I can configure Mason to always use the default npm registry.Note: I wasn't sure if I should also support it in
lua/mason-core/managers/npm/init.lua, because I could not find any references where it is used (except tests). Let me know, and I can add it if needed.