docs: add information that vim.g.python3_host_prog is used
#1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey, thanks! I'm actually not sure why it's checking that variable for python. I think I figured it'd improve the chances of finding a python executable should a user not have it in PATH. It's however inconsistent with how other system dependencies are resolved - I think we should remove usage of vim.g.python3_host_prog entirely. I'll open a separate PR for this!
|
Superseded by #1606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had some headaches wondering mason was using an outdated python version. The recent version of some packages available via mason require a more recent python, but as mason was using an older python version, they would not be able to be installed.
I figured out that it was using my system's python, and with some research figured out that it is in fact
vim.g.python3_host_progthat determines which python is used by mason. I think it is worth mentioning in the README that this variable determines what python mason uses.(Maybe it could also make sense to have a setting in the mason config to explicitly tell mason which python it should use?)