Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step size not working #92

Closed
azri92 opened this issue Dec 13, 2020 · 3 comments · Fixed by #93
Closed

Step size not working #92

azri92 opened this issue Dec 13, 2020 · 3 comments · Fixed by #93

Comments

@azri92
Copy link

azri92 commented Dec 13, 2020

Hi,

I have the following properties set:

                        app:srb_isIndicator="true"
                        app:srb_numStars="5"
                        app:srb_stepSize="1.0"
                        tools:srb_rating="2.3"

Even from preview, it can be observed that the stepSize is not being respected when rating is set. I wonder if something broke #86.

Using version 1.5.0.

@williamyyu
Copy link
Owner

Hi @azri92
From your code snippet, the stepSize is 1.0 but the rating is 2.3, which will cause the floating number being cut off.
You should probably set the stepSize to 0.1.

Cheers

@azri92
Copy link
Author

azri92 commented Dec 14, 2020

Hi @WilliamYuTW,
I actually want the step size to be 1. I put 2.3 there to see that the view only shows 2 stars. Currently, it's showing 2.3 stars even though step size is 1.0.

williamyyu added a commit that referenced this issue Dec 14, 2020
@williamyyu
Copy link
Owner

@azri92
Thanks for this! It's a bug indeed.
I'll release a fix quickly.

williamyyu added a commit that referenced this issue Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants