Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove doctests that rely on non-default features #126

Closed
williballenthin opened this issue Jul 6, 2021 · 1 comment
Closed

remove doctests that rely on non-default features #126

williballenthin opened this issue Jul 6, 2021 · 1 comment

Comments

@williballenthin
Copy link
Owner

due to rust-lang/rust#67295, i understand that we cannot conditionally enable some features when running doctests. this results in failures like https://github.com/williballenthin/lancelot/runs/3000521975?check_suite_focus=true

i've hit this issues a few times in this project, and upon reflection, realize this was the reason i didn't implement #123 earlier.

since there is no proposed fix for rust-lang/rust#67295, then we should move doctests to tests, at least when they fail due to non-default features (like test or doctest).

@williballenthin

This comment has been minimized.

williballenthin added a commit that referenced this issue Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant