Skip to content

Commit

Permalink
ci: fixing bundle size task
Browse files Browse the repository at this point in the history
  • Loading branch information
willmendesneto committed Jun 10, 2021
1 parent 3657e45 commit b788d47
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 8 deletions.
19 changes: 15 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,19 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased][]

### Added

- Adding module configuration support via `forRoot()` method. Now you can add configure your module via `forRoot()`. You can now set the default of `appearance`, `animation`, `theme`, `loadingText`, `count` and/or `items`.E.G.

```ts

@NgModule({
// ...
imports: [NgxSkeletonLoaderModule.forRoot({ appearance: 'circle', count: 3 )],
// ...
})
```
## [2.9.2][] - 2021-04-11
### Updated
Expand Down Expand Up @@ -428,7 +441,5 @@ Now we can define the animation we want to use in `<ngx-skeleton-loader>` compon
[2.9.0]: https://github.com/willmendesneto/ngx-skeleton-loader/tree/v2.9.0
[unreleased]: https://github.com/willmendesneto/ngx-skeleton-loader/compare/v2.9.1...HEAD
[2.9.1]: https://github.com/willmendesneto/ngx-skeleton-loader/tree/v2.9.1


[Unreleased]: https://github.com/willmendesneto/ngx-skeleton-loader/compare/v2.9.2...HEAD
[2.9.2]: https://github.com/willmendesneto/ngx-skeleton-loader/tree/v2.9.2
[unreleased]: https://github.com/willmendesneto/ngx-skeleton-loader/compare/v2.9.2...HEAD
[2.9.2]: https://github.com/willmendesneto/ngx-skeleton-loader/tree/v2.9.2
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"bundlesize": [
{
"path": "./dist/ngx-skeleton-loader/bundles/ngx-skeleton-loader.umd.min.js",
"maxSize": "1.7KB"
"maxSize": "1.9KB"
}
],
"dependencies": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,18 +90,18 @@ describe('NgxSkeletonLoaderComponent', () => {
}),
);

it('should console 3 errors if `animation`, `appearance` and `count` receives invalid options and is running in development mode', () => {
it('should console 3 errors if `animation`, `appearance` and `count` receives invalid options in development mode', () => {
expect(console.error).toHaveBeenCalledTimes(3);
});

it('should console errors if `animation` is an invalid option and is running in development mode', () => {
it('should console errors if `animation` is an invalid option in development mode', () => {
expect(console.error).toHaveBeenCalledWith(
// tslint:disable-next-line: max-line-length
`\`NgxSkeletonLoaderComponent\` need to receive 'animation' as: progress, progress-dark, pulse, false. Forcing default to "progress".`,
);
});

it('should console errors if `count` is an invalid option and is running in development mode', () => {
it('should console errors if `count` is an invalid option in development mode', () => {
expect(console.error).toHaveBeenCalledWith(
// tslint:disable-next-line: max-line-length
`\`NgxSkeletonLoaderComponent\` need to receive 'count' a numeric value. Forcing default to "1".`,
Expand Down

0 comments on commit b788d47

Please sign in to comment.