Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 19: Standalone defaults to true #183

Closed
GipHub123 opened this issue Jan 13, 2025 · 3 comments
Closed

Angular 19: Standalone defaults to true #183

GipHub123 opened this issue Jan 13, 2025 · 3 comments

Comments

@GipHub123
Copy link

GipHub123 commented Jan 13, 2025

Current version causes troubles with Angular 19v. Library's components are missing standalone -flag.

@Component({
standalone: false
})

NgMocks released support for V19. I run tests cases and noticed following error.
" Unexpected "MockOfNgxSkeletonLoaderComponent" found in the "declarations" array of the "MockOfNgxSkeletonLoaderModule" NgModule, "MockOfNgxSkeletonLoaderComponent" is marked as standalone and can't be declared in any NgModule - did you intend to import it instead (by adding it to the "imports" array)? ?

Versions:

ng-mocks: 14.13.2,
angular: ~19.0.5
ngx-skeleton-loader: 9.0.0
@GipHub123 GipHub123 changed the title [BUG] Angular 19: Standalone defaults to true Angular 19: Standalone defaults to true Jan 13, 2025
@TomLBarden
Copy link

I'm running into this issue too. I was looking at making a PR to address this but for whatever reason npm install fails on my fork. If I get more time I'll look into this some more, but I believe #179 addresses this issue by making the components standalone.

@willmendesneto
Copy link
Owner

I'm working on this migration at the moment. #179 is open yet, but I haven't heard from the pull request creator for a while, so I assume that was abandoned.

I'll ping you folks when I get that done. In the meantime, I would recommend you to use the approach as described in this issue comment #158 (comment)

PS: Please feel free to ping me directly here. GitHub notifications are running kinda odd to me nowadays

@willmendesneto
Copy link
Owner

And I'm more than happy to announce that: it's alive!

Please upgrade your projects to use ngx-skeleton-loader@10.0.0 and enjoy these changes in your app!

@TomLBarden @GipHub123 @yurakis

Closing this issue now. Thanks for raising that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants