-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use angular signals, standalone component #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks for your contribution. 🚀
In regards of your question of Angular deps, this package (along all angular modules in general) should cover the actively supported versions. More details in these links:
- https://angular.dev/reference/versions#actively-supported-versions
- https://angular.dev/reference/releases#actively-supported-versions
In summary, nicely done! I'm adding some comments since some checks were removed when they shouldn't and the pull request is dealing with 2 different issues at the same time, which increases the level of validation.
Feel free to ping if you need more info
projects/ngx-skeleton-loader/src/lib/ngx-skeleton-loader.component.spec.ts
Show resolved
Hide resolved
Hi! The issue this PR resolves is currently blocking my upgrade to Angular 19. Any chance of some movement on this in the near future? |
@lekhmanrus Could you solve the conflicts on the |
@willmendesneto, Absolutely! Done. Thanks! 😊 |
Thanks for the contribution, @lekhmanrus ! Massive kudos! |
And I'm more than happy to announce that: it's alive! Please upgrade your projects to use Once again, thanks @lekhmanrus for that! cc/ @TomLBarden @chimurai @yharaskrik |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
If it is a Bugfix, please describe the root cause and what could have been done to prevent it…
What is the current behavior? (You can link to an open issue here, add screenshots…)
Regular
@Input
s used as well asOnChanges
hook.What is the new behavior?
Angular Signals with build-in validation; refactored to standalone components.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration
path for existing applications: …
Other information (if applicable):
close #158
I would suggest using versions consistent with major Angular versions. Let's say ngx-skeleton-loader v18 for Angular v18, etc.
Please @mention @people to review this PR…
@willmendesneto